Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributor frontend 4 #22

Merged
merged 15 commits into from
Sep 16, 2024
Merged

Contributor frontend 4 #22

merged 15 commits into from
Sep 16, 2024

Conversation

SKairinos
Copy link
Contributor

@SKairinos SKairinos commented Sep 13, 2024

This change is Reviewable

api/serializers/agreement_signature.py Outdated Show resolved Hide resolved
api/views/agreement_signature.py Outdated Show resolved Hide resolved
Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 22 of 29 files at r1, 9 of 9 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SKairinos)


Pipfile line 26 at r2 (raw file):

[packages]
codeforlife = {ref = "contributor-frontend-4", git = "https://github.com/ocadotechnology/codeforlife-package-python.git"}

Install new package version

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

@SKairinos SKairinos merged commit 96ea83b into development Sep 16, 2024
7 of 8 checks passed
@SKairinos SKairinos deleted the contributor-frontend-4 branch September 16, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

agreement signatures page
2 participants